Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test expects / creates nodeHomeDir in default directory (~/.regen) instead of TempDirs #286

Closed
clevinson opened this issue Mar 6, 2021 · 1 comment

Comments

@clevinson
Copy link
Member

clevinson commented Mar 6, 2021

Describe the bug
Tests should be self contained. I originally noticed this issue in app/regen/cmd/TestInitCmd() and addressed in in #285. But after clearing my go test cache realize that the problem still persists, and there are probably a number of CLI tests that expect (& create if doesn't exist) a config dir in $HOME.

We probably have to do some sleuthing around to find all tests that this applies to. I assume a similar problem exists on the SDK repo with ~/.simapp.

To Reproduce
Steps to reproduce the behavior:

  1. rm -rf ~/.regen
  2. make test
  3. ls -l ~/.regen (returns a valid config dir)

Expected behavior
make test should not interact with a user's local defaultNodeHome (e.g. ~/.regen), and should rather create TempDirs.

@ryanchristo
Copy link
Member

Unable to reproduce. It looks like we are using temp directories in all tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants