From fc7bada5966ae11aa28719b21de61e90e9d15bab Mon Sep 17 00:00:00 2001
From: Markus Reiter <me@reitermark.us>
Date: Tue, 20 Feb 2024 19:36:57 +0100
Subject: [PATCH] Ensure `readall` runs without API.

---
 Library/Homebrew/cmd/readall.rb | 42 +++++++++++++++++----------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/Library/Homebrew/cmd/readall.rb b/Library/Homebrew/cmd/readall.rb
index a352ca0cf3d9df..e20db93e364a03 100644
--- a/Library/Homebrew/cmd/readall.rb
+++ b/Library/Homebrew/cmd/readall.rb
@@ -38,31 +38,33 @@ def readall_args
   def readall
     args = readall_args.parse
 
-    if args.syntax? && args.no_named?
-      scan_files = "#{HOMEBREW_LIBRARY_PATH}/**/*.rb"
-      ruby_files = Dir.glob(scan_files).grep_v(%r{/(vendor)/})
+    Homebrew.with_no_api_env do
+      if args.syntax? && args.no_named?
+        scan_files = "#{HOMEBREW_LIBRARY_PATH}/**/*.rb"
+        ruby_files = Dir.glob(scan_files).grep_v(%r{/(vendor)/})
 
-      Homebrew.failed = true unless Readall.valid_ruby_syntax?(ruby_files)
-    end
+        Homebrew.failed = true unless Readall.valid_ruby_syntax?(ruby_files)
+      end
 
-    options = {
-      aliases:     args.aliases?,
-      no_simulate: args.no_simulate?,
-    }
-    options[:os_arch_combinations] = args.os_arch_combinations if args.os || args.arch
+      options = {
+        aliases:     args.aliases?,
+        no_simulate: args.no_simulate?,
+      }
+      options[:os_arch_combinations] = args.os_arch_combinations if args.os || args.arch
 
-    taps = if args.no_named?
-      if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
-        raise UsageError, "`brew readall` needs a tap or `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
-      end
+      taps = if args.no_named?
+        if !args.eval_all? && !Homebrew::EnvConfig.eval_all?
+          raise UsageError, "`brew readall` needs a tap or `--eval-all` passed or `HOMEBREW_EVAL_ALL` set!"
+        end
 
-      Tap
-    else
-      args.named.to_installed_taps
-    end
+        Tap.select(&:installed?)
+      else
+        args.named.to_installed_taps
+      end
 
-    taps.each do |tap|
-      Homebrew.failed = true unless Readall.valid_tap?(tap, **options)
+      taps.each do |tap|
+        Homebrew.failed = true unless Readall.valid_tap?(tap, **options)
+      end
     end
   end
 end