Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group project warnings #54

Closed
simendsjo opened this issue Mar 22, 2013 · 1 comment
Closed

Group project warnings #54

simendsjo opened this issue Mar 22, 2013 · 1 comment

Comments

@simendsjo
Copy link

This is regarding dub 0.9.12

Great that you print warnings for projects, but there's a couple of issues.

  1. The project name is quite hidden in the text
  2. One warning block is printed per warning

So rather than this:

Warning
=======

The following compiler flags have been specified in pegged's
package description file. They are handled by DUB and direct use in packages is
discouraged.
Alternatively, you can set the DFLAGS environment variable to pass custom flags
to the compiler, or use one of the suggestions below:

-wi: Managed by DUB, do not specify in package.json
-property: Managed by DUB, do not specify in package.json


Warning
=======

The following compiler flags have been specified in pegged's
package description file. They are handled by DUB and direct use in packages is
discouraged.
Alternatively, you can set the DFLAGS environment variable to pass custom flags
to the compiler, or use one of the suggestions below:

-ggdb: Call dub with --build=debug

( and it goes on and on and on .. )

I wold like something like this:

Warning [project = pegged]
=======
The following compiler flags have been specified in the projects
package description file. They are handled by DUB and direct use in packages is
discouraged.
Alternatively, you can set the DFLAGS environment variable to pass custom flags
to the compiler, or use one of the suggestions below:

-wi: Managed by DUB, do not specify in package.json
-property: Managed by DUB, do not specify in package.json
-ggdb: Call dub with --build=debug

@s-ludwig
Copy link
Member

The output would now be like this:

## Warning for package pegged ##

The following compiler flags have been specified in the package description
file. They are handled by DUB and direct use in packages is discouraged.
Alternatively, you can set the DFLAGS environment variable to pass custom flags
to the compiler, or use one of the suggestions below:

-wi: Managed by DUB, do not specify in package.json
-property: Managed by DUB, do not specify in package.json
-ggdb: Call dub with --build=debug

It warned for every "dflags-" field again and multiple times for each package. It is now only checked once in a central place and all "dflags-" fields are first merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants