Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type re-export #612

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix type re-export #612

merged 1 commit into from
Dec 19, 2023

Conversation

DreierF
Copy link
Contributor

@DreierF DreierF commented Dec 19, 2023

What is the motivation for this pull request?

When importing html-dom-parser 5.0.5 from Typescript with verbatimModuleSyntax enabled the build fails with:

node_modules/.pnpm/[email protected]/node_modules/html-dom-parser/esm/types.ts:2:10 - error TS1448: 'Comment' resolves to a type-only declaration and must be re-exported using a type-only re-export when 'verbatimModuleSyntax' is enabled.

2 export { Comment, Element, ProcessingInstruction, Text };

What is the current behavior?

Typescript fails

What is the new behavior?

Typescript accepts the input

Checklist:

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DreierF! LGTM

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dfef0d) 89.62% compared to head (bb2116d) 89.62%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files           7        7           
  Lines         135      135           
  Branches       30       30           
=======================================
  Hits          121      121           
  Misses          6        6           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit 782b675 into remarkablemark:master Dec 19, 2023
5 of 6 checks passed
@remarkablemark
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants