-
-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important security consideration for using target="_blank" #413
Comments
Hello, I created PR #418 for this, I went with adding a Needed this for https://configure.ergodox-ez.com/ :) |
Doh there was already an opened PR #350 |
This can also be added through a plugin using https://github.com/remarkjs/remark-external-links |
Also in the same boat; I actually tried the workaround suggested by |
The suggested solution is the plugin mentioned above; there will be a release soon which fixes support for plugins |
Using
target="_blank"
on hyperlinks without usingrel="noopener"
is a problem, because the opened page can access and modify some properties on the opening page.You can find out more information here:
https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/
Proposed fix
Automatically add
rel="noopener noreferrer"
to all links that are targeting_blank
, or makerel
user-accessible liketarget
The text was updated successfully, but these errors were encountered: