Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React version to React 17 (peerDependencies) #497

Closed
casperiv0 opened this issue Oct 24, 2020 · 6 comments · Fixed by #498
Closed

Update React version to React 17 (peerDependencies) #497

casperiv0 opened this issue Oct 24, 2020 · 6 comments · Fixed by #498
Labels
🏗 area/tools This affects tooling 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have

Comments

@casperiv0
Copy link
Contributor

Subject of the feature

Update React version to React 17 in peerDependencies

Problem

react-markdown does not support React 17

Expected behavior

Support the latest version of React.

Alternatives

/
@casperiv0 casperiv0 added 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Oct 24, 2020
@wooorm
Copy link
Member

wooorm commented Oct 24, 2020

Do you get a warning that React 17 isn’t supported, or does something actually crash?

@casperiv0
Copy link
Contributor Author

Hi,

I'm getting an error when installing it from npm (see image).

Thanks for your fast response.

image

@wooorm
Copy link
Member

wooorm commented Oct 24, 2020

Are you on npm 7 already? (npm --version)

If so, try the --legacy-peer-deps for now.

I was looking into React 17 a day or so ago, and it all worked well. However, this project is using enzyme-adapter-react-16 and in dev-dependencies, and there isn’t a enzyme-adapter-react-17 yet, so I was waiting on that.

@casperiv0
Copy link
Contributor Author

Alright, will do. Thanks for your help.

@rexxars rexxars mentioned this issue Oct 24, 2020
Merged
@wooorm
Copy link
Member

wooorm commented Nov 19, 2020

Released!

@wooorm wooorm closed this as completed Nov 19, 2020
@wooorm wooorm added ⛵️ status/released 🏗 area/tools This affects tooling 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have and removed 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have labels Nov 19, 2020
@casperiv0
Copy link
Contributor Author

Thankyou!

@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏗 area/tools This affects tooling 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests on React 17 remarkjs/react-markdown
2 participants
@wooorm @casperiv0