-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History 1.14 pushState deprecation warnings. #2657
Comments
See #2659 as well. We could cut it down to not include the new feature. Still blocked on remix-run/history#173 though. |
I don't understand the question. You should be able to use 1.14 without any
|
React Router itself is still using |
My direct use of history is with push (and has been for some time). It's react-rotuer that causes the deprecation warnings from history. I realize that react-router 1.1 will make this issue moot. Just asking if there can be a patch release that only addresses the correct usage of history 1.14 in the meantime. |
Ah, sorry. I thought this issue was opened on the history project.
|
history updated to 1.14.0 which deprectates `pushState`, resulting in a console warning (`Warning: [history] pushState is deprecated; use push instead`) from `<Link>`. This will go away once react-router 1.1 is released. remix-run/react-router#2657
For now, just |
This was fixed by #2659 against the latest |
Will there be an interim 1.0.2 release that correctly uses history's push ahead of the larger 1.1 release?
I'm holding my project's history at 1.13.1 to prevent the warnings, because they are presented via console.error and not console.warn, which is very distracting while developing.
The text was updated successfully, but these errors were encountered: