Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History 1.14 pushState deprecation warnings. #2657

Closed
uipoet opened this issue Dec 6, 2015 · 7 comments
Closed

History 1.14 pushState deprecation warnings. #2657

uipoet opened this issue Dec 6, 2015 · 7 comments

Comments

@uipoet
Copy link

uipoet commented Dec 6, 2015

Will there be an interim 1.0.2 release that correctly uses history's push ahead of the larger 1.1 release?

I'm holding my project's history at 1.13.1 to prevent the warnings, because they are presented via console.error and not console.warn, which is very distracting while developing.

@taion
Copy link
Contributor

taion commented Dec 6, 2015

See #2659 as well. We could cut it down to not include the new feature. Still blocked on remix-run/history#173 though.

@mjackson
Copy link
Member

mjackson commented Dec 6, 2015

I don't understand the question. You should be able to use 1.14 without any
warnings if you don't do deprecated stuff. Is that not the case?
On Sun, Dec 6, 2015 at 12:05 PM Jimmy Jia [email protected] wrote:

See #2659 #2659 as well. We
could cut it down to not include the new feature. Still blocked on
remix-run/history#173 remix-run/history#173 though.


Reply to this email directly or view it on GitHub
#2657 (comment)
.

@taion
Copy link
Contributor

taion commented Dec 6, 2015

React Router itself is still using pushState and replaceState though, via e.g. <Link> and what it does for onEnter hooks.

@uipoet
Copy link
Author

uipoet commented Dec 7, 2015

My direct use of history is with push (and has been for some time). It's react-rotuer that causes the deprecation warnings from history. I realize that react-router 1.1 will make this issue moot. Just asking if there can be a patch release that only addresses the correct usage of history 1.14 in the meantime.

@mjackson
Copy link
Member

mjackson commented Dec 7, 2015

Ah, sorry. I thought this issue was opened on the history project.
On Sun, Dec 6, 2015 at 5:34 PM Jamie Hoover ⚔ [email protected]
wrote:

My direct use of history is with push (and has been for some some). It's
react-rotuer that causes the deprecations warnings from history. I realize
that react-router 1.1 will make this issue moot. Just asking if there can
be a patch release that only addresses the correct usage of history 1.14 in
the meantime.


Reply to this email directly or view it on GitHub
#2657 (comment)
.

claus added a commit to MadeInHaus/react-flux-gulp-starter that referenced this issue Dec 7, 2015
history updated to 1.14.0 which deprectates `pushState`, resulting in a console warning (`Warning: [history] pushState is deprecated; use push instead`) from `<Link>`. This will go away once react-router 1.1 is released.

remix-run/react-router#2657
@timdorr
Copy link
Member

timdorr commented Dec 7, 2015

For now, just npm install --save [email protected] in your project. No need for an interim release.

@taion
Copy link
Contributor

taion commented Dec 8, 2015

This was fixed by #2659 against the latest history release. We'll get a new React Router release out as soon as we can. Thank for your patience.

@taion taion closed this as completed Dec 8, 2015
jlegrone added a commit to Bernie-2016/ground-control that referenced this issue Dec 12, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants