Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history.back() doesn't work in ios Chrome (need to update history to > 4.4.1) #4365

Closed
KaboomFox opened this issue Jan 23, 2017 · 3 comments
Closed

Comments

@KaboomFox
Copy link

Version

2.0.0 3.0.0

Test Case

http://jsbin.com/sacerobuxi/edit?html,js,output

Steps to reproduce

Related to: #2565
On ios Chrome window.history.back() does not work. This was fixed in the https://github.com/mjackson/history/pull/208/files v4.4.1. If we update History. This will no longer be an issue.

Expected Behavior

You are redirect to the previous page

Actual Behavior

Nothing happens

@timdorr
Copy link
Member

timdorr commented Jan 23, 2017

You linked to the wrong PR on history. It's actually at remix-run/history#383

This just needs to be backported to history 3.x and it will fix things here. You should open up an equivalent issue over there, as there's nothing to fix on this library.

@timdorr timdorr closed this as completed Jan 23, 2017
@timdorr
Copy link
Member

timdorr commented Jan 23, 2017

Also, this is the equivalent line in history to that PR (in case you want to submit a PR, which would be better!): https://github.com/mjackson/history/blob/v3.x/modules/BrowserProtocol.js#L46-L47

@KaboomFox
Copy link
Author

@timdorr thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants