Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RRN <Link to> support for location object #4476

Closed
FreddieRidell opened this issue Feb 6, 2017 · 2 comments
Closed

RRN <Link to> support for location object #4476

FreddieRidell opened this issue Feb 6, 2017 · 2 comments

Comments

@FreddieRidell
Copy link
Contributor

Version: 4.0.0-beta.4

Native links function fine using object style to props, could the propTypes be changed to reflect this, if this is allowable behaviour?

I'll make a PR if you're accepting them
@pshrmn pshrmn changed the title Native Link accept object style to Update react-router-native' <Link> prop types to support location objects Feb 6, 2017
@pshrmn pshrmn changed the title Update react-router-native' <Link> prop types to support location objects Update RRN <Link>'s "to" prop type to support location objects Feb 6, 2017
@mjackson mjackson changed the title Update RRN <Link>'s "to" prop type to support location objects RRN <Link to> support for location object Feb 7, 2017
@mjackson
Copy link
Member

mjackson commented Feb 7, 2017

Yes, @CodogoFreddie, RRN's <Link to> should support location objects. If you'd like to add support, be my guest :)

@FreddieRidell
Copy link
Contributor Author

FreddieRidell commented Feb 7, 2017 •
edited
Loading

done: #4483 🔗 👍

@timdorr timdorr closed this as completed Feb 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timdorr @mjackson @FreddieRidell