Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add DataFunctionArgs type export into 6.4 #8942

Closed
DaveLo opened this issue Jun 7, 2022 · 1 comment · Fixed by #8947 or #8975
Closed

[Feature]: Add DataFunctionArgs type export into 6.4 #8942

DaveLo opened this issue Jun 7, 2022 · 1 comment · Fixed by #8947 or #8975
Labels

Comments

@DaveLo
Copy link

DaveLo commented Jun 7, 2022

What is the new or updated feature that you are suggesting?

I was following along with the getting started with Data example in the docs in typescript when I ran into a missing type for loader functions. It is working with inlined loaders so I wouldn't classify this as a bug, but is missing from the types export for react-router-dom

To demonstrate here is a sandbox where I define an empty loader inline and can see the type info, but can't add that same type to my loader directly.

Why should this feature be included?

This should be included for improved DX in typescript apps

@brophdawg11
Copy link
Contributor

Fixed in #8975 - will be released with the next prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants