Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update <Link> to just call push #2658

Closed
wants to merge 1 commit into from
Closed

Update <Link> to just call push #2658

wants to merge 1 commit into from

Conversation

taion
Copy link
Contributor

@taion taion commented Dec 6, 2015

No description provided.

@taion
Copy link
Contributor Author

taion commented Dec 6, 2015

Tests will fail until remix-run/history#173 is merged and released.
Codemod: reactjs/rackt-codemod#5.

I'm still using context.history here - we could potentially merge this and release it before the API changes to get rid of the deprecation warnings for users, per remix-run/history#172 (comment).

@taion
Copy link
Contributor Author

taion commented Dec 6, 2015

On second thought, I'm going to re-make this PR from a branch on this repo instead of my personal fork. I'm going to be extremely busy over the next week and a half or so, and someone else might have to shepherd this to release.

@taion taion closed this Dec 6, 2015
@taion taion deleted the Link-props branch December 6, 2015 20:03
@taion taion mentioned this pull request Dec 6, 2015
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taion