dev 1.18.0 error when using React v17

[SeanGroff]

What version of Remix are you using?

1.18.0

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

Setup a basic Remix project that uses Remix 1.18.0 and React/React-dom version 17.
Someting like create remix app then downgrade React.
Enable the new HMR dev server in the remix config.
Run npm run dev

An error occurs:

cc: @pcattori Issue filed as requested on Discord

Expected Behavior

The dev server serves up the local site without errors

Actual Behavior

Error "Could not resolve react-dom/client"

[pcattori]

Can you try adding a .catch() to the offending import within your node_modules/? Just to verify if that does anything.

// node_modules/@remix-run/dev/dist/config/defaults/entry.dev.ts

export default () => {
  import("react");
  import("react/jsx-dev-runtime");
  import("react/jsx-runtime");
  import("react-dom");
  import("react-dom/client").catch();
  import("react-refresh/runtime");
  import("@remix-run/react");
  import("remix:hmr");
};

[joshmedeski]

Hey @pcattori, I'm having the same problem and catching the react-dom/client import fixed it!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-0657c16-20230630 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.18.1-pre.2 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-7abaf9f-20230701 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.19.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.19.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!