Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable inferring credentials from environment variables #12155

Closed
fgreinacher opened this issue Oct 13, 2021 · 3 comments · Fixed by #12294 or #12488
Closed

Disable inferring credentials from environment variables #12155

fgreinacher opened this issue Oct 13, 2021 · 3 comments · Fixed by #12294 or #12488
Labels
core:config Related to config capabilities and presets status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@fgreinacher
Copy link
Contributor

fgreinacher commented Oct 13, 2021

(Originally discussed at #12118)

What would you like Renovate to be able to do?

I don't want Renovate to guess credentials from my environment variables so that I have full control over which credentials are presented to which registry.

If you have any ideas on how this should be implemented, please tell us here.

I'd like to have a configuration option to disable this behavior. Maybe inferCredentialsFromEnv?

Is this a feature you are interested in implementing yourself?

Yes

@fgreinacher fgreinacher added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Oct 13, 2021
@viceice viceice added the core:config Related to config capabilities and presets label Oct 13, 2021
@rarkins
Copy link
Collaborator

rarkins commented Oct 14, 2021

Maybe model it on https://docs.renovatebot.com/self-hosted-configuration/#detectglobalmanagerconfig ?

Instead of it being in the "env parsing" logic (which would mean you could only disable it with another env variable) it instead could be performed as a secondary step after basic config parsing is done.

Could also be named similarly: detectHostRulesFromEnv

Finally, maybe we should do another major version bump and default it to disabled

@viceice
Copy link
Member

viceice commented Oct 14, 2021

Yeah, i like that idea.

As I know the current feature i always need to think about how to pass credentials via env which don't trigger this automatic parsing.

😉

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 29.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
4 participants