Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning in pr body #17609

Merged
merged 28 commits into from
Sep 12, 2022

Conversation

MaronHatoum
Copy link
Contributor

@MaronHatoum MaronHatoum commented Sep 4, 2022

Changes

  1. warnings has been added to PR body
  2. display a relevant warnings msg (dependencyDashboard=true/false) in pr body

Context

closes #16924

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@MaronHatoum
Copy link
Contributor Author

Examples from real repository:

{
  "dependencyDashboard": true
}

MaronHatoum/warnings-in-PR-bodies#55

{
  "dependencyDashboard": false
}

MaronHatoum/warnings-in-PR-bodies#56

Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

lib/workers/repository/update/pr/body/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/body/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more fixes to the text.

lib/workers/repository/errors-warnings.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/errors-warnings.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/body/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/body/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/body/index.spec.ts Outdated Show resolved Hide resolved
@MaronHatoum
Copy link
Contributor Author

MaronHatoum commented Sep 6, 2022

I think we had a misunderstanding about the purpose of this issue. I have updated it in #16924 so that it is clearer. There should be no impact on the onboarding PR

is this the expected result?

onboarding PR: MaronHatoum/pr-warnings#2
dependencyDashboard=true: MaronHatoum/pr-warnings#6
dependencyDashboard=false: MaronHatoum/pr-warnings#5

@MaronHatoum MaronHatoum requested review from viceice, betterPeleg and HonkingGoose and removed request for betterPeleg September 7, 2022 07:19
@MaronHatoum MaronHatoum marked this pull request as ready for review September 7, 2022 07:20
@rarkins rarkins enabled auto-merge (squash) September 12, 2022 08:47
@rarkins rarkins merged commit c741649 into renovatebot:main Sep 12, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.195.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show warnings indication in non-onboarding PR bodies
8 participants