Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker/java): add workaround to limit releases to java LTS versions #18007

Merged
merged 15 commits into from
Oct 4, 2022
Merged

feat(docker/java): add workaround to limit releases to java LTS versions #18007

merged 15 commits into from
Oct 4, 2022

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Sep 27, 2022

Changes

Add a workaround which limits the Java versions to LTS releases only.

Context

Discussion on #8127

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy
Copy link
Collaborator Author

setchy commented Sep 27, 2022 •
edited
Loading

@rarkins - I've run this on https://github.com/setchy/renovate-java-test

Two questions

Question 1
These rules currently don't maintain the image version precision (in our organization we mandate semver where possible)

The dockerfile has eclipse-temurin:11-jre and the two suggested PRs are suggesting

  • PR 1 - 11.0.16_8-jre and
  • PR 2 - 17.0.4_8-jre

Before merging we should probably address this

Question 2
Should this be part of workarounds:all, or a standalone opt-in workaround?

@setchy setchy mentioned this pull request Sep 27, 2022
Open
@setchy setchy marked this pull request as draft September 27, 2022 16:08
@setchy setchy marked this pull request as ready for review September 28, 2022 18:00
rarkins
rarkins reviewed Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include this one too?

image

@setchy
Copy link
Collaborator Author

setchy commented Oct 3, 2022

Can we include this one too?

image

I believe 19 is a non-LTS. Would you want this in the same workaround?

@setchy
Copy link
Collaborator Author

setchy commented Oct 3, 2022

I have questions on IF/WHEN this becomes a workaround, how would someone override/exclude it Incase they wanted each major release (6-monthly)?

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

They would need to add this workaround to ignoredPresets

@rarkins
Copy link
Collaborator

rarkins commented Oct 3, 2022

Can we include this one too?
image

I believe 19 is a non-LTS. Would you want this in the same workaround?

I want to suppress the example in the screenshot.

HonkingGoose
HonkingGoose reviewed Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a comment from a reviewer into a proper PR comment, so we don't miss it. 😉

lib/config/presets/internal/workarounds.ts Show resolved Hide resolved
setchy added 3 commits October 3, 2022 12:06
@setchy
feat(docker/java): consolidate rule and extend to adoptium-java datas…
4345a5f 
…ource

expand versioning regex
widen allowed versions to support 8, along with the next 3 unreleased LTS
@setchy
Merge branch 'feature/java-lts-workaround' of https://github.com/setc…
b7f261b 
…hy/renovate into feature/java-lts-workaround
@setchy
feat(docker/java): remove commented out rule
d43cd01
@setchy
Copy link
Collaborator Author

setchy commented Oct 3, 2022

Can we include this one too?
image

I believe 19 is a non-LTS. Would you want this in the same workaround?

I want to suppress the example in the screenshot.

Updated the workaround rule to include adoptium-java datasources

@setchy
Copy link
Collaborator Author

setchy commented Oct 3, 2022

I have run this against a demonstration project - see https://github.com/setchy/renovate-java-test/pulls

HonkingGoose
HonkingGoose suggested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

docs/usage/java.md Outdated Show resolved Hide resolved
docs/usage/java.md Outdated Show resolved Hide resolved
docs/usage/java.md Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Oct 4, 2022
View reviewed changes
@setchy @HonkingGoose
Update docs/usage/java.md
86293b9 
Co-authored-by: HonkingGoose <[email protected]>
@setchy @HonkingGoose
Update docs/usage/java.md
1ab96a4 
Co-authored-by: HonkingGoose <[email protected]>
@setchy @HonkingGoose
Update docs/usage/java.md
3b67e6b 
Co-authored-by: HonkingGoose <[email protected]>
rarkins
rarkins previously approved these changes Oct 4, 2022
View reviewed changes
@rarkins rarkins enabled auto-merge (squash) October 4, 2022 15:40
@rarkins rarkins merged commit ac5ec2b into renovatebot:main Oct 4, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.216.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose mentioned this pull request Oct 5, 2022
Merged
6 tasks
@setchy setchy deleted the feature/java-lts-workaround branch October 12, 2022 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
@setchy setchy added the type:feature Feature (new functionality) label May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose requested changes

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@setchy @rarkins @renovate-release @viceice @HonkingGoose