Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the steps of Fork and Clone #18287

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Conversation

edutrul
Copy link
Contributor

@edutrul edutrul commented Oct 12, 2022

Changes

Modified in the Fork and Clone steps, so that it is understood how to solve the GitHub token access problem.

Context

Documentation (please check one with an [x])

  • I have updated the documentation so that the steps in Fork and Clone can be better understood

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should link to the getting started page instead. as you can also use ENV to configure the token.

@rarkins
Copy link
Collaborator

rarkins commented Oct 12, 2022

The token part is already covered about 30 lines later (it advises env or CLI)

@edutrul
Copy link
Contributor Author

edutrul commented Oct 13, 2022

Thank you for your comments.

Yeah, it is covered 30 lines later, but as a first committer to this project, I am following step by step from top to bottom, and that was a stopper for me. Wondering if could move these 30 lines before so that when following the tutorial, it can be easy to follow instructions.

@rarkins rarkins changed the title Update the steps of Fork and Clone docs: update the steps of Fork and Clone Dec 8, 2022
@rarkins rarkins enabled auto-merge (squash) December 8, 2022 08:42
@rarkins rarkins disabled auto-merge December 8, 2022 10:29
@rarkins rarkins merged commit 41c14d2 into renovatebot:main Dec 8, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants