Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "short" GitHub Actions tag comments #18640

Closed
rarkins opened this issue Oct 28, 2022 · 2 comments · Fixed by #18738
Closed

Support "short" GitHub Actions tag comments #18640

rarkins opened this issue Oct 28, 2022 · 2 comments · Fixed by #18738
Assignees
Labels
manager:github-actions Github actions manager priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Oct 28, 2022

What would you like Renovate to be able to do?

Support not only our standard GitHub tag pinning syntax of uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7 # tag=v3.0.11 but also uses: actions/cache@9b0c1fce7a93df8e3bb8926b0d6e9d89e92f20a7 # v3.0.11.

If you have any ideas on how this should be implemented, please tell us here.

To avoid false positive matches (e.g. # cache action) we should support only these patterns:

v?\d+
v?\d+\.\d+
v?\d+\.\d+\.\d+

(I'm sure there's a more efficient regex, that's ok)

This check should be done as part of extract if we don't match the # tag=v explicit syntax.

Ideally we could prefer this syntax too, e.g. convert any compliant tag=v... comments into v... comments.

Is this a feature you are interested in implementing yourself?

No

@rarkins rarkins added type:feature Feature (new functionality) priority-2-high Bugs impacting wide number of users or very important features manager:github-actions Github actions manager status:ready labels Oct 28, 2022
@rarkins
Copy link
Collaborator Author

rarkins commented Nov 1, 2022

Let's reuse the test cases from Dependabot: https://github.com/dependabot/dependabot-core/blob/45f52b300ae163d6fb221fceb7965e016eaf84de/github_actions/spec/fixtures/workflow_files/pinned_sources_version_comments.yml#L7-L30

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 34.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:github-actions Github actions manager priority-2-high Bugs impacting wide number of users or very important features type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants