Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update labels when config changes #25340

Merged
merged 71 commits into from
Mar 30, 2024
Merged

feat: update labels when config changes #25340

merged 71 commits into from
Mar 30, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Oct 23, 2023 •
edited
Loading

Changes

Old behavior:

  • PR labels aren't updated when labels are changed in repo config

New behavior:

  • PR labels are updated when labels are changed in repo config, except when PR labels have been modified by user OR the PR was created with old logic ie. only PRs created after this new logic is merged are affected.

Context

Closes: #22496

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh

This comment was marked as outdated.

Sign in to view
RahulGautamSingh
RahulGautamSingh commented Oct 23, 2023
View reviewed changes
@RahulGautamSingh RahulGautamSingh marked this pull request as draft October 23, 2023 04:12
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review October 23, 2023 14:29
@RahulGautamSingh RahulGautamSingh marked this pull request as draft October 24, 2023 04:13
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review October 24, 2023 12:22
viceice
viceice reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also store the labels inside renovate cache? so it would work on platforms without html comments as long as the cache is persisted

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Oct 24, 2023 •
edited
Loading

should we also store the labels inside renovate cache? so it would work on platforms without html comments as long as the cache is persisted

Good idea 💡.
Since it is a different implementation wise, I will add that in a follow-up PR.

HonkingGoose
HonkingGoose suggested changes Feb 19, 2024
View reviewed changes
rarkins
rarkins requested changes Feb 21, 2024
View reviewed changes
HonkingGoose
HonkingGoose approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs.

rarkins
rarkins reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to do some repo testing first before merging

@RahulGautamSingh
Copy link
Collaborator Author

I want to do some repo testing first before merging

Should I retest, or do you want to do it yourself?

@rarkins
Copy link
Collaborator

rarkins commented Feb 21, 2024

I assume you've tested the latest code :)

I'll also test

rarkins
rarkins previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after testing

@rarkins
Copy link
Collaborator

rarkins commented Feb 28, 2024

@viceice please merge if looks good to you

@rarkins rarkins added this pull request to the merge queue Mar 30, 2024
Merged via the queue into renovatebot:main with commit f889079 Mar 30, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.277.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

secustor pushed a commit to secustor/renovate that referenced this pull request Mar 31, 2024
@RahulGautamSingh @rarkins
@viceice @HonkingGoose @secustor
feat: update labels when config changes (renovatebot#25340)
4764d0c 
Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: HonkingGoose <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update labels when config changes
5 participants
@RahulGautamSingh @viceice @rarkins @renovate-release @HonkingGoose