fix: disable docker:pinDigests for ArgoCD #30556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drafting this again since I may have found additional managers impacted by this. |
morremeyer
force-pushed
the
fix/docker-pin-digest-argocd
branch
from
2329fc4 to
bdf9c33
Compare
|
Updated the PR to also not pin digests for the |
rarkins
approved these changes
Aug 3, 2024
|
🎉 This issue has been resolved in version 38.18.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This disables Docker digest pinning for the ArgoCD manager in the
docker:pinDigestspreset.Context
The
argocdmanager uses the Docker datasource only for helm chart target versions.However, helm does not yet support digest pinning, see
Trying to pin them anyway leads to
WARN: Error updating branch: update failurewarnings from renovate.The same applies to the
helmv3manager, when it tries to pin the chart version of an OCI chart in aChart.yamlfile.Because pinning is not supported, pinning digests for helm charts should be disabled in these managers.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I updated the Anaconda base configuration in anaconda/renovate-config#101 to have the same configuration as this PR, which was successful for our repositories and resolved all
WARN: Error updating branch: update failureerrors.