Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Renovating helm charts #3414

Closed
rarkins opened this issue Mar 20, 2019 · 6 comments · Fixed by #3805
Closed

Support Renovating helm charts #3414

rarkins opened this issue Mar 20, 2019 · 6 comments · Fixed by #3805
Assignees
Labels
help wanted Help is needed or welcomed on this issue manager:dockerfile Dockerfile files new package manager New package manager support priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 20, 2019

No description provided.

@rarkins rarkins added type:feature Feature (new functionality) help wanted Help is needed or welcomed on this issue ready priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:dockerfile Dockerfile files labels Mar 20, 2019
@prateeknayak
Copy link

prateeknayak commented Mar 20, 2019

+1 for this issue

Looks like following code is what checks if it is updating kubernetes manifests or not and skips values.yaml even if it is found by the regex.

const isKubernetesManifest =
    content.match(/\s*apiVersion\s*:/) && content.match(/\s*kind\s*:/);
  if (!isKubernetesManifest) {
    return null;
  }

Could this check be skipped somehow? or do you reckon a new manager needs to be implemented for this?

@rarkins
Copy link
Collaborator Author

rarkins commented Mar 20, 2019

Disclaimer: I don't use kubernetes or helm daily, but it sounded to me like they're different managers even if the syntax is similar. I assume there would need to be other if/else checks and logic differences between k8s and helm too?

Cc @mxey who wrote the k8s part originally

@prateeknayak
Copy link

Thanks for your quick response.

Another manager sounds good, but I think the code base would be pretty similar. Because yamls in helm charts are templated manifests.

Also, I would also like to understand how renovate would handle

  • multiple images in a one deployment manifest
  • multiple deployment manifests in one repo

@rarkins
Copy link
Collaborator Author

rarkins commented Mar 20, 2019

In Renovate it's pretty common to have multiple package files per repo and multiple dependencies per package file, so Helm would be no different. Each dependency is tracked to a package file, which is identified by file name. The way dependencies within a package file are identified varies per-manager. In this case it's probably done by line number.

@srueg
Copy link
Contributor

srueg commented Oct 11, 2019

This looks like an awesome feature. Thanks @nchashch for your work!

I would also be interested in having support for Helm release CRDs like the flux Helm operator uses: https://docs.fluxcd.io/projects/helm-operator/en/latest/references/helmrelease-custom-resource.html

I guess the indexer could be reused from this?

@renovate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 19.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Help is needed or welcomed on this issue manager:dockerfile Dockerfile files new package manager New package manager support priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants