Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax highlighting on string concatenation with text tags #170

Closed
multimokia opened this issue Jul 16, 2022 · 3 comments · Fixed by #330
Closed

Incorrect syntax highlighting on string concatenation with text tags #170

multimokia opened this issue Jul 16, 2022 · 3 comments · Fixed by #330
Assignees
Labels
bug Something isn't working topic:syntax
Milestone

Comments

@multimokia
Copy link
Contributor

Extension version

2.1.1

Issue description

image

As shown in the image, the + quip + in both say calls are highlighted as strings despite not being within quotation marks.

Scope inspector screenshots

image
image

Code

label test:
    $ quip = "some quiplist choice"
    $ renpy.say(m, "{cps=*3}" + quip + "{/cps}")

    python:
        renpy.say(m, "{cps=*3}" + quip + "{/cps})

    return
@duckdoom4 duckdoom4 added the bug Something isn't working label Jul 16, 2022
@duckdoom4
Copy link
Collaborator

duckdoom4 commented Jul 16, 2022

Awesome, thanks for this. That makes the issue a lot more clear.
I'm currently unable to check myself. Could you tell me if this also happens outside of python blocks/$ lines

@multimokia
Copy link
Contributor Author

Sure.
image

In this case the closing tag not being present is a typo, but we see the behaviour is still present, and will span multiple lines.
image

@duckdoom4
Copy link
Collaborator

Thanks for the update. I'll look into it when I find the time :)

@duckdoom4 duckdoom4 self-assigned this Jul 18, 2022
@LuqueDaniel LuqueDaniel added this to the 2.2.1 milestone Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:syntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants