Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to delete/remove labels #80

Closed
patcon opened this issue Apr 5, 2018 · 3 comments
Closed

Support to delete/remove labels #80

patcon opened this issue Apr 5, 2018 · 3 comments
Labels

Comments

@patcon
Copy link

patcon commented Apr 5, 2018

Hi again!

I'm seeing the ability to delete/remove labels in settings/lib/plugins/labels.js, but am I correct in finding that it hasn't been implemented yet?

It seems fairly niche, but for creating starter project templates for tech and GitHub beginners, it would be nice to clean-up the default GitHub labels to make things as clear as possible, in case they don't suit a project type :)

Any preference on how this might be done? My first inclination is to allow this would be to allow one of these:

# option A
labels:
  - name: wontfix
    delete: true

# option B
labels:
  - deletename: wontfix

# option C
labels:
  - oldname: wontfix

Before I jump in, can anyone offer advice on:

  • What's possible with current arch?
  • Are any of the above are good or bad patterns?

Thanks!

@patcon patcon changed the title Support for removing labels Support to delete/remove labels Apr 5, 2018
@knrt10
Copy link

knrt10 commented Apr 6, 2018

@patcon this is really a nice idea. It can surely help beginners. If I am right it can be implemented with the current architecture. You have to make changes in settings/lib/plugins/labels.js file to implement these changes, if I am right about what you want to do. You need to add some parameters in .github/settings.yml file to so that you can get the attributes from them and try them to update or delete them using the functions in settings/lib/plugins/labels.js file.

@patcon
Copy link
Author

patcon commented Apr 6, 2018

Hm. I'm reading through, and thinking maybe I'm not reasoning around this correctly, but... is this already removing labels that aren't mentioned explicitly in the settings.yml: https://github.com/probot/settings/blob/32a359d4c6104d789fe9c95691492d04660b753e/lib/plugins/diffable.js#L46-L50

EDIT: no pressure to reply, i will learn myself later, and maybe contribute some small changes that try to may make it more legible to a rookie programmer like myself :)

@stale
Copy link

stale bot commented Jun 5, 2018

Is this still relevant? If so, please comment with any updates or addition details.

@stale stale bot added the wontfix label Jun 5, 2018
@stale stale bot closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants