From dad92e8a267860e0b99c40850210e62ee0ccfc07 Mon Sep 17 00:00:00 2001
From: PascalRepond <pascal.repond@rero.ch>
Date: Mon, 8 Aug 2022 15:36:41 +0200
Subject: [PATCH] deposits: harmonize field validations

* `volume`, `number` and `pages` deposit fields should not reject values
that are accepted by the equivalent fields in the document.
* Allows more flexibility for submitters and prevents API rejections.
* Closes #878.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
---
 .../deposits/deposit-v1.0.0_src.json          | 22 ++-----------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/sonar/modules/deposits/jsonschemas/deposits/deposit-v1.0.0_src.json b/sonar/modules/deposits/jsonschemas/deposits/deposit-v1.0.0_src.json
index d61d669e..58f9c435 100644
--- a/sonar/modules/deposits/jsonschemas/deposits/deposit-v1.0.0_src.json
+++ b/sonar/modules/deposits/jsonschemas/deposits/deposit-v1.0.0_src.json
@@ -572,16 +572,10 @@
               "title": "Volume",
               "type": "string",
               "minLength": 1,
-              "pattern": "^[0-9]+$",
               "form": {
                 "hideExpression": "field.parent.parent.model && !['coar:c_beb9', 'coar:c_6501', 'coar:c_998f', 'coar:c_dcae04bc'].includes(field.parent.parent.model.documentType)",
                 "templateOptions": {
-                  "placeholder": "Example: 1"
-                },
-                "validation": {
-                  "messages": {
-                    "patternMessage": "Please enter a valid number."
-                  }
+                  "placeholder": "Example: 1, 4-5, …"
                 }
               }
             },
@@ -589,16 +583,10 @@
               "title": "Number",
               "type": "string",
               "minLength": 1,
-              "pattern": "^[0-9]+$",
               "form": {
                 "hideExpression": "field.parent.parent.model && !['coar:c_beb9', 'coar:c_6501', 'coar:c_998f', 'coar:c_dcae04bc'].includes(field.parent.parent.model.documentType)",
                 "templateOptions": {
-                  "placeholder": "Example: 10"
-                },
-                "validation": {
-                  "messages": {
-                    "patternMessage": "Please enter a valid number."
-                  }
+                  "placeholder": "Example: 10, 22-24, …"
                 }
               }
             },
@@ -606,15 +594,9 @@
               "title": "Pages",
               "type": "string",
               "minLength": 1,
-              "pattern": "^[0-9]+(-[0-9]+)?$",
               "form": {
                 "templateOptions": {
                   "placeholder": "Examples: 135, 5-27, …"
-                },
-                "validation": {
-                  "messages": {
-                    "patternMessage": "Please enter a valid pages range, example: 135, 5-27."
-                  }
                 }
               }
             },