From 51a5e065900a90a8399ec332820e42deb8324500 Mon Sep 17 00:00:00 2001 From: Emil Ernerfeldt Date: Thu, 27 Apr 2023 11:00:37 +0200 Subject: [PATCH] Don't use console.error (#1984) Because it can apparaently cause crashes: https://github.com/emilk/egui/pull/2961 --- crates/re_log/src/web_logger.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/crates/re_log/src/web_logger.rs b/crates/re_log/src/web_logger.rs index c9851188b0e8e..5c6cf353cdcbc 100644 --- a/crates/re_log/src/web_logger.rs +++ b/crates/re_log/src/web_logger.rs @@ -31,7 +31,11 @@ impl log::Log for WebLogger { log::Level::Debug => console::debug(&msg), log::Level::Info => console::info(&msg), log::Level::Warn => console::warn(&msg), - log::Level::Error => console::error(&msg), + + // Using console.error causes crashes for unknown reason + // https://github.com/emilk/egui/pull/2961 + // log::Level::Error => console::error(&msg), + log::Level::Error => console::warn(&format!("ERROR: {msg}")), } } @@ -60,8 +64,10 @@ mod console { #[wasm_bindgen(js_namespace = console)] pub fn warn(s: &str); - /// `console.error` - #[wasm_bindgen(js_namespace = console)] - pub fn error(s: &str); + // Using console.error causes crashes for unknown reason + // https://github.com/emilk/egui/pull/2961 + // /// `console.error` + // #[wasm_bindgen(js_namespace = console)] + // pub fn error(s: &str); } }