Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "groups" as a concept from the DataResultTree. #4441

Closed
Tracked by #4899
jleibs opened this issue Dec 5, 2023 · 0 comments · Fixed by #5326
Closed
Tracked by #4899

Deprecate "groups" as a concept from the DataResultTree. #4441

jleibs opened this issue Dec 5, 2023 · 0 comments · Fixed by #5326
Assignees
Labels
🟦 blueprint The data that defines our UI ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Dec 5, 2023

As part of #4899 we need to update the way that the DataResultTree is presented in the UI:

  • The existing notion of "Groups" goes away. Every node in the tree is an entity path and the hierarchy should match that of the tree.
    • Open design question: the group-elements in the current DataQueryResult currently have their override path set to the the recursive override root. Without the existence of selectable group-elements it's unclear how recursive overrides should be set. Recursive overrides could be a separate section of the selection panel, or a checkbox next to the different UI elements such as "apply to children".

Mock-up of future UI:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants