Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a placeholder item to indicate the destination when the "Add SV/Container" modal is open #4958

Open
Tracked by #3120
abey79 opened this issue Jan 30, 2024 · 3 comments
Assignees
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 30, 2024

As the title says ☝🏻

For now, this should be done only if design and implementation is easy.

@abey79 abey79 changed the title display a placeholder item to indicate the destination when the "Add SV/Container" modal is open Display a placeholder item to indicate the destination when the "Add SV/Container" modal is open Jan 30, 2024
@abey79 abey79 added the ui concerns graphical user interface label Jan 30, 2024
@abey79 abey79 self-assigned this Jan 30, 2024
@abey79
Copy link
Member Author

abey79 commented Feb 5, 2024

@nikolausWest how we feel about something like this?

Image

@nikolausWest
Copy link
Member

The indentation in that example seems off by one (would expect it to look like it's a sibling node to "/" here, not a child) but other than that this seems reasonable to me (design is shippable but definitely room for improvement in the future)

@abey79
Copy link
Member Author

abey79 commented Feb 5, 2024

Yeah, I agree the box should encompass the collapsing triangle area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants