Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile for FreeBSD #6367

Open
yurivict opened this issue May 17, 2024 · 11 comments
Open

Can't compile for FreeBSD #6367

yurivict opened this issue May 17, 2024 · 11 comments
Labels
dependencies concerning crates, pip packages etc enhancement New feature or request good first issue Good for newcomers

Comments

@yurivict
Copy link

Arc-blroth/memory-stats#9

Memory stats shouldn't be an absolutely required feature. It's better to have rerun buildable without memory stats than not buildable at all.

@yurivict yurivict added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels May 17, 2024
@Wumpf Wumpf added good first issue Good for newcomers and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels May 17, 2024
@Wumpf
Copy link
Member

Wumpf commented May 17, 2024

Should be easy enough to accommodate for this, but I wouldn't be surprised if there's more issues when building for FreeBSD

@emilk
Copy link
Member

emilk commented May 17, 2024

I think this should be fixed in memory-stats instead - it should ideally compile on every platform, but return None on unsupported platforms.

@emilk
Copy link
Member

emilk commented May 17, 2024

…but I guess that crate isn't getting much love these days: Arc-blroth/memory-stats#8

@yurivict
Copy link
Author

IMO, it is easier to add a compile-time switch in rerun to unblock this issue.
Then, if memory-status would change later - this can be adopted, when they change.

@emilk
Copy link
Member

emilk commented May 20, 2024

For sure - just excluding memory-stats on BSD sounds like a good idea. Do you wanna make a PR?

@emilk
Copy link
Member

emilk commented May 20, 2024

…or better yet, I think memory-stats can be replaced by https://crates.io/crates/sys-info

@emilk emilk changed the title Please make memory-stats optional based on compile-time switch because it doesn't yet support BSDs Can't compile for FreeBSD May 20, 2024
@emilk emilk added the dependencies concerning crates, pip packages etc label May 20, 2024
@dakshbtc
Copy link

dakshbtc commented May 26, 2024

Can i pick this . please @emilk

@emilk
Copy link
Member

emilk commented May 27, 2024

Since Arc-blroth/memory-stats#8 is merged we're only waiting for a new release of memory-stats to have this solved.

@emilk
Copy link
Member

emilk commented May 27, 2024

@dakshbtc do you want to replace our use of memory-stats with sys-info?

@dakshbtc
Copy link

dakshbtc commented Jun 1, 2024

@emilk yes i can do that.

@dakshbtc
Copy link

dakshbtc commented Jun 1, 2024

it is just being used in ./rerun/crates/re_memory/src/memory_use.rs file currently. Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants