Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KillRuntime => startAndKillRuntimeRetainsTheState e2e test seems to be flaky #2573

Open
tillrohrmann opened this issue Jan 29, 2025 · 7 comments
Labels
tests flaky tests or other test related issues

Comments

@tillrohrmann
Copy link
Contributor

We have multiple instances where the KillRuntime => startAndKillRuntimeRetainsTheState e2e test fails because after the runtime restarts the subsequent Counter.add call does not complete. There is a suspicious comment https://github.com/restatedev/sdk-test-suite/blob/fb737ce392eaea6038c9103930d95c721bf609e9/src/main/kotlin/dev/restate/sdktesting/tests/KillRuntime.kt#L50-L51 about docker messing up the exposed ports.

Failing test runs:

https://github.com/restatedev/restate/actions/runs/12926599283/job/36050876168?pr=2508
https://github.com/restatedev/restate/actions/runs/13021279660/job/36323280404#step:11:175

@tillrohrmann tillrohrmann added the tests flaky tests or other test related issues label Jan 29, 2025
@tillrohrmann
Copy link
Contributor Author

@tillrohrmann
Copy link
Contributor Author

@slinkydeveloper do you have time looking into what's going wrong here?

@tillrohrmann
Copy link
Contributor Author

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Jan 31, 2025

I'm gonna push a patch, hoping it fixes the issue. If not, I propose to just go and remove this test, it's not adding so much at the end of the day, and I rather prefer that a test killing the runtime is moved in the runtime tests.

I'm honestly short on ideas here :(

@tillrohrmann
Copy link
Contributor Author

Could we add a request timeout (something like 5s) and then retry the add invocation?

@slinkydeveloper
Copy link
Contributor

let me try to do that

@slinkydeveloper
Copy link
Contributor

updated the test suite, let's see if it still fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests flaky tests or other test related issues
Projects
None yet
Development

No branches or pull requests

2 participants