-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify use cases and tests for input data #1
Comments
Hey! I'm interested for sure but I'm pretty busy for the next week or so. I'll try to get back to this then :) |
I did some poking and testing at this over the weekend and even though this seems like it should work (which is the deserializer mode that we're using), it my tests it doesn't seem to work in my (high level) tests. The really confusing wording in the documentation is:
That seems to cover both newline and other concatenated values. 🤷🏻 My tests were pretty high level so some unittests might be good, I'll poke at that next as I have time. |
Ok, I posted that comment and #5 does resolve this. |
I've been looking at this and related libraries for processing some JSON stream data, and I was explicitly looking for a tool that would handle non new-line delimited JSON. While this library says that it's for processing new-line json, there isn't any code that handles newline separations, and I believe from looking at the implementation that it should handle streams of multi-line json documents just fine.
It might be nice to add a few test cases and tweak some of the documentation to reflect this. Would you all be interested in this?
The text was updated successfully, but these errors were encountered: