Make templates return results properly instead of abusing .Scratch

[palant]

The initial commit fixes #137. I also could fail to notice that hrefTargetBlank processing in markdownify.html seems very inefficient - let me know if I missed something that the original code was doing better.

I must say that I didn't test the changes to content.html fully - it's way too many branches and settings. But the changes are pretty straightforward.

I want to add more commits to this pull request, there are other templates following the same pattern.

[palant]

Somewhat more extensive changes to auto-detect-images.html and images.html - these implemented pretty much the same logic concerning the image host. Now this logic is applied to the entire list of images, regardless of where the images came from. Also, auto-detect-images.html template now only executes as a fallback instead of executing even when it isn't needed.

[reuixiy]

I also could fail to notice that hrefTargetBlank processing in markdownify.html seems very inefficient

Yeah... That was awkward, I'm not sure why I wrote that way now. 🤣

I must say that I didn't test the changes to content.html fully

I have tested it and everything works fine.

Somewhat more extensive changes to auto-detect-images.html and images.html

Love this refactoring!

[palant]

Side-notes: title.html will only pass page titles through plainify, not other titles - looks wrong. Also, images.html should probably recognize image names from the page bundle, something for another pull request.

[palant]

The changes to relative-url.html are more extensive again. The ./ prefix is unnecessary for a relative URL, so the template could be simplified. I also got rid of an unnecessary safeJS call in service-worker.html - I could verify that the code was emitted correctly here but I cannot test the functionality.

[palant]

It seems that I am done here. The change to utils/tree-sections.html is completely untested however because I have no idea under which circumstances this template is being used.

[reuixiy]

categoryBy = "sections"
↳ layouts/section/categories.html
↳ layouts/partials/pages/tree-sections.html
↳ Generated something like this page but for sections.

In other words, I want to implement a categories page that displays like the output of tree command. So I created utils/tree-sections.html for this, although I don't know if there is a better way.

[reuixiy]

@palant Everything works well except the last commit, which returns an empty map[].

Also, there are more .Scratchs we can remove, something for another pull request again. (To be honest, I didn't know the = operator until I found it in your commits.)

BTW, do you mind if I invite you as a collaborator of this repository? 😊

[palant]

Ok, I rolled back that last change. It's probably that one scenario where one actually has to use .Scratch - blocks cannot access external variables, and they cannot return a result either.

↳ Generated something like this page but for sections.

Yes, I got this in theory but couldn't make that page generated.

BTW, do you mind if I invite you as a collaborator of this repository? 😊

I guess that's ok but I cannot promise regular contributions.

[reuixiy]

I guess that's ok but I cannot promise regular contributions.

No problem. I have invited you, and after you accept it, you should be able to merge this PR. 😊

Additionally, the commit messages, please follow the Conventional Commits, as MemE's changelog is based on it.

Thanks again :)

[palant]

So the title of this commit should be "BREAKING CHANGE: Make templates return results properly instead of abusing .Scratch (#153)", right?

[reuixiy]

Hmmm, refactor sounds better,

refactor: Make templates return results properly (#153)

...instead of abusing .Scratch

Fixes #137

[...]

[palant]

Well, it is a breaking change for anybody overriding templates 😄

[reuixiy]

Then maybe we can add it in the footer, I guess.

refactor: Make templates return results properly (#153)

...instead of abusing .Scratch

Fixes #137

[...]

BREAKING CHANGE: <description>