refactor: Make title.html partial more readable, fix title for taxonomy pages #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…my pages BREAKING CHANGE: Markdown in page titles will be processed now
|
I noticed another oversight: search index wasn't adjusted, so it was using unprocessed titles. So in search results you would see unprocessed Markdown code. While at it, I also applied |
|
@reuixiy Please merge this PR. Titles for taxonomy pages are broken |
Actually, there are more issues here - fixed them all in #190. |
reuixiy
approved these changes
Jun 7, 2020
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
…my pages (reuixiy#187) * refactor: Make title.html partial more readable, fix title for taxonomy pages * fix: Search index does not respect Markdown in page titles BREAKING CHANGE: Markdown in page titles will be processed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #183 (comment), I renamed the variables to make the logic more clear. I also fixed the title for taxonomy pages (#183 introduced a bug, making it "security: security" instead of "Categories: security") and removed unnecessary code (massaging the title for regular pages no longer necessary).
Finally, I added a "BREAKING CHANGE" note to this commit because #183 didn't. I checked the output for my blog, there are lots of changes, mostly due to the typographer extension now doing its job on the titles. In my case these changes all seem unproblematic.