Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept header parsing rejects valid headers #220

Closed
ashokdelphia opened this issue Apr 29, 2019 · 3 comments
Closed

Accept header parsing rejects valid headers #220

ashokdelphia opened this issue Apr 29, 2019 · 3 comments
Assignees
Labels

Comments

@ashokdelphia
Copy link
Contributor

I'm using Chrome Version 73.0.3683.86, and the accept header it makes for regular web pages is:

Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3

With the new Accept header parsing in v3.10.0, the last entry is rejected with:

    "application/signed-exchange;v=b3" is not a valid media type

Apologies for not catching that in review for PR #216.

I think to properly follow the production in RFC 7231, we should allow other parameters and only care if q is set.

@nwolff
Copy link

nwolff commented May 7, 2019

Just to clarify, installing django-health-check 3.10.0 and requesting the healthcheck page returns a 500:

2019-05-07-102102_758x251_scrot

@ashokdelphia
Copy link
Contributor Author

Just to clarify, installing django-health-check 3.10.0 and requesting the healthcheck page returns a 500:

Yes. #221 should fix that.

@ashokdelphia
Copy link
Contributor Author

This is fixed in v3.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants