From c8f996fa639f400045c4b206905426d993ca2f1c Mon Sep 17 00:00:00 2001 From: dasMulli Date: Fri, 29 Jan 2021 15:21:45 +0100 Subject: [PATCH] Fix inconsistend ordering for build listing API Fixes #934 --- .../XplatGenerateReleaseNotes/V3/ReleaseNotesFunctions.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Extensions/XplatGenerateReleaseNotes/V3/ReleaseNotesFunctions.ts b/Extensions/XplatGenerateReleaseNotes/V3/ReleaseNotesFunctions.ts index dee905f31..9c94b3c95 100644 --- a/Extensions/XplatGenerateReleaseNotes/V3/ReleaseNotesFunctions.ts +++ b/Extensions/XplatGenerateReleaseNotes/V3/ReleaseNotesFunctions.ts @@ -797,12 +797,19 @@ export async function getLastSuccessfulBuildByStage( } } + builds.sort((a, b) => b.queueTime - a.queueTime); + + let foundSelf = false; + for (let buildIndex = 0; buildIndex < builds.length; buildIndex++) { const build = builds[buildIndex]; agentApi.logInfo (`Comparing ${build.id} against ${buildId}`); // force the cast to string as was getting a type mimatch if (build.id.toString() === buildId.toString()) { agentApi.logInfo("Ignore compare against self"); + foundSelf = true; + } else if (!foundSelf) { + agentApi.logInfo(`Ignoring ${build.id} (${build.buildNumber}) since not yet reached the current build`); } else { if (tags.length === 0 || (tags.length > 0 && build.tags.sort().join(",") === tags.sort().join(","))) {