Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World's Fair data #718

Merged
merged 2 commits into from
Aug 12, 2024
Merged

World's Fair data #718

merged 2 commits into from
Aug 12, 2024

Conversation

jonthegeek
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@tracykteal tracykteal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@lgibson7 lgibson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Jon!

@jonthegeek
Copy link
Collaborator Author

/assign worldfair 2024-08-13

@lgibson7
Copy link
Member

lgibson7 commented Aug 12, 2024

So the heavy lifting looks to be in the cleaning script. I'll dig into a few other weeks as well to get a better idea before tackling my own.

One suggestion I have for eliciting data set submissions is moving the request earlier in the README to the bottom of "How to participate"; just a short blurb directing folks to CONTRIBUTING.md and instructions.md. Currently "Submitting Datasets" is at the very bottom of the README and only mentions submitting issues rather than PRs.

@jonthegeek jonthegeek merged commit c179ea0 into master Aug 12, 2024
@jonthegeek jonthegeek deleted the worldsfair branch August 12, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants