Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shroomish's backsprite has him levitating #1496

Closed
AsparagusEduardo opened this issue May 20, 2021 · 6 comments
Closed

Shroomish's backsprite has him levitating #1496

AsparagusEduardo opened this issue May 20, 2021 · 6 comments
Labels
category: pokemon Pertains to Pokémon data and functionality

Comments

@AsparagusEduardo
Copy link
Collaborator

Title
image

@Blackforest92
Copy link

The levitating part is because of the spriter using HGSS's official sprite.
It looks weird for me as well, cutting 4 pixels from below should fix it.
However,
I think everyone need to decide if the fix is necessary since this is taken from official sprite.

Comparison :
HGSS : https://img.pokemondb.net/sprites/heartgold-soulsilver/back-normal/shroomish.png
DP : https://img.pokemondb.net/sprites/diamond-pearl/back-normal/shroomish.png

@LOuroboros
Copy link
Collaborator

The levitating part is because of the spriter using HGSS's official sprite.
It looks weird for me as well, cutting 4 pixels from below should fix it.
However,
I think everyone need to decide if the fix is necessary since this is taken from official sprite.

Comparison :
HGSS : https://img.pokemondb.net/sprites/heartgold-soulsilver/back-normal/shroomish.png
DP : https://img.pokemondb.net/sprites/diamond-pearl/back-normal/shroomish.png

There's no need to cut anything at all. Increasing the value of Shroomish's back sprite's Y coord by 1 or 2 in src/data/pokemon_graphics/back_pic_coordinates.h should be more than enough.

@LOuroboros LOuroboros added category: pokemon Pertains to Pokémon data and functionality category: pokemon labels May 21, 2021
@Blackforest92
Copy link

Increasing the value of Shroomish's back sprite's Y coord by 1 or 2

The rest of the sprites in our repo are all matching with their data in src/data/pokemon_graphics/back_pic_coordinates.h.
Beside all i need to do is adjusting the position of the graphic and port the shiny.pal into it.
At the same time, pushing a fix to #1488 and graphical glitch of Xerneas Active as well.

@LOuroboros
Copy link
Collaborator

Increasing the value of Shroomish's back sprite's Y coord by 1 or 2

The rest of the sprites in our repo are all matching with their data in src/data/pokemon_graphics/back_pic_coordinates.h.

I'm not sure what do you mean by that. The coordinates are normally set based on the sprite, so it can be properly positioned on the screen and so you won't have to fiddle with the sprite itself pointlessly.

I mean, that's normally what I used to do to fix the position of a sprite in battle. Leave the sprite alone and tweak its Y position as needed. I thought that was par for the course.

@Blackforest92
Copy link

I'm not sure what do you mean by that.

While your solution does solve the problem, i just feel that since the all pokemon graphic (.png files) in our repo are matching with the Y coordinate code. It just kinda feel wrong to add 2 - 4 points to into Shroomish's Y position while its graphic is 9px counted up from below, which is currently matching with its code.
I just want the graphic file to match the code.

Nevertheless, both solutions work. Either just push fix to the one .png or edit the Y position.
Both are 30secs fixes.

@DizzyEggg
Copy link
Collaborator

#1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: pokemon Pertains to Pokémon data and functionality
Projects
None yet
Development

No branches or pull requests

4 participants