Battle Bond doesn't transform when fainting ally

[AsparagusEduardo]

Found by akimoto#5337 on RHH's discord

[LOuroboros]

Can't confirm. It's working just fine in a clean copy of the upcoming branch.

EDIT: Fwiw though, this brought to my attention that maybe we should adjust the check at VARIOUS_TRY_ACTIVATE_BATTLE_BOND, because currently, it always checks for CalculateEnemyPartyCount() > 1. It probably isn't checking the Player's or an AI ally's own party if you decide to attack your ally.

[DizzyEggg]

Cannot reproduce the check on upcoming. Could anyone else try this?

Also, I don't think it's necessary to change CalculateEnemyPartyCount, it does what it needs to do imo

[AlexOn1ine]

Tried to reproduce but everything seemed fine.

[LOuroboros]

Also, I don't think it's necessary to change CalculateEnemyPartyCount, it does what it needs to do imo

Does it?

I mean, I provided a logical example with the AI ally, but what if it's the enemy's BB Greninja that performs the fainting? Wouldn't the ability's code still use CalculateEnemyPartyCount which reads gEnemyParty, when it should be using CalculatePlayerPartyCount instead?