Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Problem with calling ShouldSwitch inside AI Calcs #3277

Closed
ghoulslash opened this issue Sep 4, 2023 · 2 comments
Closed

Potential Problem with calling ShouldSwitch inside AI Calcs #3277

ghoulslash opened this issue Sep 4, 2023 · 2 comments
Assignees
@DizzyEggg
Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet

Comments

@ghoulslash
Copy link
Collaborator

Description

ShouldSwitch will run through the battle controller data emit functions if switching should be performed. This is potentially problematic during AI calcs by maybe stomping on other data? Suggestion would be to pass an argument through ShouldSwitch, e.g. "bool32 emitResult" to safely use it in the AI calcs

Version

1.5.3 (Default)

Upcoming Version

No response

Discord contact info

No response
@ghoulslash ghoulslash added bug Bug status: unconfirmed This bug has not been reproduced yet category: battle-ai Pertains to Battle Engine Upgrade's AI labels Sep 4, 2023
@AlexOn1ine
Copy link
Collaborator

I wonder if issue #2672 is related to this.

@DizzyEggg DizzyEggg mentioned this issue Dec 20, 2023
Closed
@DizzyEggg DizzyEggg self-assigned this Dec 21, 2023
@DizzyEggg DizzyEggg mentioned this issue Dec 21, 2023
Merged
@Bassoonian
Copy link
Collaborator

Fixed by #3784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DizzyEggg DizzyEggg

Labels
bug Bug category: battle-ai Pertains to Battle Engine Upgrade's AI status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DizzyEggg @Bassoonian @ghoulslash @AlexOn1ine