Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install instructions for WSL1 #5028

Closed
pkmnsnfrn opened this issue Jul 23, 2024 · 3 comments
Closed

Update install instructions for WSL1 #5028

pkmnsnfrn opened this issue Jul 23, 2024 · 3 comments
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet type: documentation Improvements or additions to documentation

Comments

@pkmnsnfrn
Copy link
Collaborator

Description

From pret#2016

It turns out that Microsoft changed WSL such that the default is now WSL2, and also broke the link to the Microsoft Store in the INSTALL.md. This PR aims to fix this.
I did not test building the project completely from scratch from the available machine I could use to install WSL, however, I did test that the instructions do install WSL running version 1 correctly.

I imagine we should check and update our INSTALL.md to match.

Version

master (default, unreleased bugfixes)

Upcoming/master Version

No response

Discord contact info

pkmnsnfrn
@pkmnsnfrn pkmnsnfrn added bug Bug status: unconfirmed This bug has not been reproduced yet labels Jul 23, 2024
@Bassoonian
Copy link
Collaborator

Shouldn't this be fixed in pret's install instead?

@pkmnsnfrn
Copy link
Collaborator Author

The PR that I linked is to fix it for pret. I created this issue because I want to make sure somebody remembers to check if our install.md is ALSO outdated in a similar way.

@hedara90 hedara90 added the type: documentation Improvements or additions to documentation label Jul 26, 2024
@pkmnsnfrn
Copy link
Collaborator Author

pkmnsnfrn commented Jul 27, 2024 •
edited
Loading

fixed by #5045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bassoonian @pkmnsnfrn @hedara90