Uproar test potentially wrong

[ghoulslash]

Description

The uproar test (https://github.com/rh-hideout/pokeemerald-expansion/blob/master/test/battle/move_effect/uproar.c#L9) assigns Voltorb soundproof but also expects it to wake up from soundproof, which is incorrect behavior according to

pokeemerald-expansion/src/battle_util.c

Line 2664 in 1c022f4

&& GetBattlerAbility(gBattlerAttacker) != ABILITY_SOUNDPROOF)

.

Conversation/GIF starts here: https://discord.com/channels/419213663107416084/1077009799293710357/1290119643612184718

Version

1.9.2 (Latest release)

Upcoming/master Version

No response

Discord contact info

No response

[AlexOn1ine]

While a Pokémon is making an uproar, Pokémon cannot fall asleep (even if they have Soundproof or are not adjacent to the Pokémon making the uproar). Pokémon can be made drowsy by Yawn, but a drowsy Pokémon cannot fall asleep during an uproar (even if it has Soundproof).

According to Bulbapedia this is correct behavior

[AlexOn1ine]

discussed on discord