From 4d4b5e5282b0f14c23030404a24aa521d2ea600c Mon Sep 17 00:00:00 2001 From: Bassoonian Date: Tue, 16 Jan 2024 19:27:08 +0100 Subject: [PATCH] Deprecate GetBerryCountString --- include/item.h | 1 - src/berry.c | 11 +++-------- src/item.c | 15 --------------- 3 files changed, 3 insertions(+), 24 deletions(-) diff --git a/include/item.h b/include/item.h index c9c38543cd81..041e9d8ba050 100644 --- a/include/item.h +++ b/include/item.h @@ -39,7 +39,6 @@ void ApplyNewEncryptionKeyToBagItems_(u32 newKey); void SetBagItemsPointers(void); void CopyItemName(u16 itemId, u8 *dst); void CopyItemNameHandlePlural(u16 itemId, u8 *dst, u32 quantity); -void GetBerryCountString(u8 *dst, const u8 *berryName, u32 quantity); bool8 IsBagPocketNonEmpty(u8 pocket); bool8 CheckBagHasItem(u16 itemId, u16 count); bool8 HasAtLeastOneBerry(void); diff --git a/src/berry.c b/src/berry.c index b747b2e19c9d..477bb92d372e 100644 --- a/src/berry.c +++ b/src/berry.c @@ -1982,11 +1982,6 @@ void GetBerryNameByBerryType(u8 berry, u8 *string) string[BERRY_NAME_LENGTH] = EOS; } -void GetBerryCountStringByBerryType(u8 berry, u8 *dest, u32 berryCount) -{ - GetBerryCountString(dest, GetBerryInfo(berry)->name, berryCount); -} - void AllowBerryTreeGrowth(u8 id) { GetBerryTreeInfo(id)->stopGrowth = FALSE; @@ -2122,7 +2117,7 @@ void ObjectEventInteractionGetBerryTreeData(void) gSpecialVar_0x8004 = GetStageByBerryTreeId(id); gSpecialVar_0x8005 = GetNumStagesWateredByBerryTreeId(id); gSpecialVar_0x8006 = GetBerryCountByBerryTreeId(id); - GetBerryCountStringByBerryType(berry, gStringVar1, gSpecialVar_0x8006); + CopyItemNameHandlePlural(BerryTypeToItemId(berry), gStringVar1, gSpecialVar_0x8006); } void ObjectEventInteractionGetBerryName(void) @@ -2136,12 +2131,12 @@ void ObjectEventInteractionGetBerryCountString(void) u8 treeId = GetObjectEventBerryTreeId(gSelectedObjectEvent); u8 berry = GetBerryTypeByBerryTreeId(treeId); u8 count = GetBerryCountByBerryTreeId(treeId); - GetBerryCountStringByBerryType(berry, gStringVar1, count); + CopyItemNameHandlePlural(BerryTypeToItemId(berry), gStringVar1, count); berry = GetTreeMutationValue(treeId); if (berry > 0) { count = 1; - GetBerryCountStringByBerryType(berry, gStringVar3, count); + CopyItemNameHandlePlural(BerryTypeToItemId(berry), gStringVar3, count); gSpecialVar_Result = TRUE; } else diff --git a/src/item.c b/src/item.c index b0813efdf5a6..e102af726618 100644 --- a/src/item.c +++ b/src/item.c @@ -101,21 +101,6 @@ void CopyItemNameHandlePlural(u16 itemId, u8 *dst, u32 quantity) StringAppend(end, sText_s); } -void GetBerryCountString(u8 *dst, const u8 *berryName, u32 quantity) -{ - const u8 *berryString; - u8 *txtPtr; - - if (quantity < 2) - berryString = gText_Berry; - else - berryString = gText_Berries; - - txtPtr = StringCopy(dst, berryName); - *txtPtr = CHAR_SPACE; - StringCopy(txtPtr + 1, berryString); -} - bool8 IsBagPocketNonEmpty(u8 pocket) { u8 i;