Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target management clusters in SSS #207

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

jan--f
Copy link
Collaborator

@jan--f jan--f commented Oct 26, 2022

Signed-off-by: Jan Fajerski [email protected]

@jan--f jan--f requested a review from a team as a code owner October 26, 2022 17:19
@jan--f jan--f requested review from sthaha and slashpai October 26, 2022 17:19
@apahim
Copy link
Collaborator

apahim commented Oct 26, 2022

MON-2677 is about deploying OBO to the entire OSD/ROSA fleet, which can be achieved by using the label:

api.openshift.com/managed: "true"

Why are we targeting Management Clusters only?

@jan--f jan--f force-pushed the change-sss-label-selector branch from a56e3b8 to 6b85458 Compare October 26, 2022 18:09
@jan--f
Copy link
Collaborator Author

jan--f commented Oct 26, 2022

MON-2677 is about deploying OBO to the entire OSD/ROSA fleet, which can be achieved by using the label:

api.openshift.com/managed: "true"

Why are we targeting Management Clusters only?

My bad, fixed now

@jan--f jan--f force-pushed the change-sss-label-selector branch from 6b85458 to 71f41b1 Compare October 27, 2022 06:33
Copy link
Member

@maorfr maorfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jan--f jan--f merged commit b660849 into rhobs:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants