Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some typos and reconciliation of optional UIPlugin components #491

Merged
merged 4 commits into from
May 27, 2024

Conversation

xperimental
Copy link
Contributor

These commits have been extracted from #477, so that they can be separately reviewed and merged quicker.

PTAL @jgbernalp

@xperimental xperimental self-assigned this May 27, 2024
@xperimental xperimental requested a review from a team as a code owner May 27, 2024 12:59
@xperimental xperimental requested review from sthaha and JoaoBraveCoding and removed request for a team May 27, 2024 12:59
@openshift-ci openshift-ci bot requested a review from machine424 May 27, 2024 13:00
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09dd760 into rhobs:main May 27, 2024
11 checks passed
@xperimental xperimental deleted the drive-by-fixes branch May 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants