Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COO-180: fix: bind service with correct container port for korrel8r #504

Merged
merged 1 commit into from
Jun 7, 2024
Merged

COO-180: fix: bind service with correct container port for korrel8r #504

merged 1 commit into from
Jun 7, 2024

Conversation

jgbernalp
Copy link
Contributor

use correct port for korrel8r deployment so the service binds correctly

@jgbernalp jgbernalp requested a review from a team as a code owner June 7, 2024 11:59
@jgbernalp jgbernalp requested review from danielmellado and simonpasquier and removed request for a team June 7, 2024 11:59
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 7, 2024 •
edited by openshift-ci bot
Loading

@jgbernalp: This pull request references COO-180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

use correct port for korrel8r deployment so the service binds correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jan--f and machine424 June 7, 2024 12:00
@jgbernalp
Copy link
Contributor Author

FYI @shwetaap @alanconway

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
simonpasquier
simonpasquier reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@danielmellado
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jgbernalp, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@shwetaap
Copy link
Contributor

shwetaap commented Jun 7, 2024

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit 4edf774 into rhobs:main Jun 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@periklis periklis periklis approved these changes

@danielmellado danielmellado Awaiting requested review from danielmellado danielmellado is a code owner automatically assigned from rhobs/observability-operator-maintainers

@jan--f jan--f Awaiting requested review from jan--f

@machine424 machine424 Awaiting requested review from machine424

Assignees

@periklis periklis

@shwetaap shwetaap

@simonpasquier simonpasquier

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgbernalp @openshift-ci-robot @danielmellado @shwetaap @periklis @simonpasquier