-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump Prometheus operator to v0.74.0 #518
feat: bump Prometheus operator to v0.74.0 #518
Conversation
e5b95ea
to
f9c7fe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marioferh, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0d56b6f
to
4fbf72e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
is no shellheck, is this test after the enableGate type change:
let me fix it |
4fbf72e
to
897485a
Compare
in fact before the expected was:
as right now.. if: then: observability-operator/pkg/controllers/monitoring/monitoring-stack/components.go Line 188 in 95cc348
there was a bug before? |
Signed-off-by: Mario Fernandez <[email protected]>
b8b42dc
to
364eaaf
Compare
Signed-off-by: Mario Fernandez <[email protected]>
364eaaf
to
1c6fbf9
Compare
no bug but an upstream change that broke the test :) prometheus-operator/prometheus-operator@3e0d0f86f2 /lgtm |
/unhold |
No description provided.