COO-225: fix: Add support for ConsolePlugin v1 #530
Conversation
jgbernalp
requested review from
jan--f and
sthaha
and removed request for
a team
|
@jgbernalp: This pull request references COO-225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jgbernalp
force-pushed
the
add-support-for-console-plugin-v1
branch
from
d57b75b to
e3ae8d6
Compare
jgbernalp
changed the title
jgbernalp
force-pushed
the
add-support-for-console-plugin-v1
branch
from
e3ae8d6 to
3c9ec68
Compare
| @@ -45,14 +48,32 @@ var ( | |||
| korrel8rConfigYAMLTmplFile embed.FS | |||
| ) | |||
|
|
|||
| func pluginComponentReconcilers(plugin *uiv1alpha1.UIPlugin, pluginInfo UIPluginInfo) []reconciler.Reconciler { | |||
| func isClusterVersionAheadOrEqual(clusterVersion, nextClusterVersion string) bool { | |||
There was a problem hiding this comment.
a nitpicking, feels the variable names of isClusterVersionAheadOrEqual is unreasonable and confusing, maybe better change as func isClusterVersionAheadOrEqual(currentClusterVersion, clusterVersion string) bool {
There was a problem hiding this comment.
Yeah I agree, the naming is awkward currently. I see how future devs might think the clusterVersion in the name is related to the variable name.
There was a problem hiding this comment.
updated to func isVersionAheadOrEqual(currentVersion, version string) bool {
|
Verified the bug COO-225 with this PR, the issue is gone on OCP4.17 |
jgbernalp
force-pushed
the
add-support-for-console-plugin-v1
branch
2 times, most recently
from
d63783d to
3fcfbf0
Compare
jgbernalp
force-pushed
the
add-support-for-console-plugin-v1
branch
from
3fcfbf0 to
9ce360b
Compare
|
/lgtm |
|
/lgtm |
This PR adds support for ConsolePlugin CR v1 for OCP 4.17. For older versions the v1alpha1 support was kept