Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update RBAC to include listing TempoMonolithic CRs #545

Conversation

andreasgerstmayr
Copy link
Contributor

Update RBAC to include listing TempoMonolithic CRs.
Soon the Distributed Tracing UI Plugin will support Tempo deployments in monolithic mode (TempoMonolithic CR).

https://issues.redhat.com/browse/OU-490

cc @jgbernalp

@andreasgerstmayr andreasgerstmayr requested a review from a team as a code owner August 9, 2024 13:35
@andreasgerstmayr andreasgerstmayr requested review from sthaha and slashpai and removed request for a team August 9, 2024 13:35
@openshift-ci openshift-ci bot requested review from simonpasquier and tremes August 9, 2024 13:35
Copy link

openshift-ci bot commented Aug 9, 2024

Hi @andreasgerstmayr. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3aa199d into rhobs:main Aug 9, 2024
11 checks passed
lihongyan1 pushed a commit to lihongyan1/observability-operator that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants