Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Telemetry Deserialization Issue #190

Closed
nirajpatel opened this issue Dec 8, 2016 · 5 comments
Closed

Telemetry Deserialization Issue #190

nirajpatel opened this issue Dec 8, 2016 · 5 comments

Comments

@nirajpatel
Copy link

nirajpatel commented Dec 8, 2016 •
edited
Loading

Hi! It seems like in version 0.7.0 of consul the following String should be an array.

https://github.com/OrbitzWorldwide/consul-client/blob/a4cfd6aa94ad430c17872069205b427f26a75bbc/src/main/java/com/orbitz/consul/model/agent/Telemetry.java#L33

I have tested making that change locally and everything seems to work properly.
@rickfast
Copy link
Owner

rickfast commented Dec 8, 2016

If you already made the change locally can you make a PR then?

@rickfast
Copy link
Owner

rickfast commented Dec 9, 2016

fixed 68039e8

@rickfast rickfast closed this as completed Dec 9, 2016
@nirajpatel
Copy link
Author

Thanks @rickfast! Next time I will send a PR. Sorry about that. When will the next release be cut?

@rickfast
Copy link
Owner

0.13.6 is now available in central and bintray

@nirajpatel
Copy link
Author

Thank you sir :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rickfast @nirajpatel