Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Prepared query with template #242

Closed
elleFlorio opened this issue Jun 27, 2017 · 5 comments
Closed

Prepared query with template #242

elleFlorio opened this issue Jun 27, 2017 · 5 comments

Comments

@elleFlorio
Copy link
Contributor

Hi,

I was trying to create a prepared query using a template, but I couldn't figure out how to do it. Looking into the code, seems that the PreparedQuery class doesn't have a field to store the template. Is it a "bug" or am I missing something?

Thanks.

@elleFlorio
Copy link
Contributor Author

Anyway, if it is a bug I fixed it. If you want I can do a pull request. ;-)

@rickfast
Copy link
Owner

Looks like a bug - forgot to add the field to PQ :/ PR is welcome. I can release a new version after

@elleFlorio
Copy link
Contributor Author

Ok, thank you! I also added a method to get all the prepared queries stored in consul (i.e., the API endpoint GET /v1/queries), can I add this modification to the PR?

Thanks

@rickfast
Copy link
Owner

Yup

@elleFlorio
Copy link
Contributor Author

Ok, done. Thanks!

@rickfast rickfast closed this as completed Jul 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants