Link service integration causes feed autodiscovery to accumulate generated entries #2
Assignees
Labels
halp wanted
SEND HALP
Comments
|
Now that Firefox has abandoned the built-in feed reader and Live Bookmarks since version 64, I was wondering if you are still working on this. The reason I ask, is that there's some issues with the implementation of RSS and Atom in PeerTube due to the default content-disposition Firefox uses for links that end with filetypes .xml and .atom. Firefox wants to download these "files" (which aren't static files) based on their file extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sorry for the weird title, but there really isn't any clearer way to describe the problem.
This issue covers 7914ab8
CONTEXT
I'm trying to add RSS/ATOM feed autodiscovery by adding
<link>entries in the<head>part of the page on certain pages. See the standard.What feed autodiscovery generally looks like?
How browsers implement it?
https://html.spec.whatwg.org/#rel-alternate
What certain pages?
Actually, certain views since that's what Angular understands. It means we'll get to modify the current dom to emulate page changes. Maybe that's messing with the browser implementation though, I don't know.
PROBLEM
Welp, look at the commit message.
Indeed, at each view change, the current set of
<link>entries should be deleted, and new ones added so that they correspond to the new view's feeds. But instead they aggregate in the browser's RSS autodiscovery tab. It could be a bug on Firefox's side, but I have a record of pebkac…Okay, a picture is worth a thousand words. (this is Firefox 59.0.2 btw)
Now, could it be that the DOM elements don't get deleted? Nope, there are always 3 entries (JSON-feed won't get displayed by Firefox but we don't really care for now).
So, how does DOM manipulation get done in
LinkService, and Angular more generally?Before digging any deeper, know that I built
LinkServicebased on seminal work here angular/angular#15776 (comment)It leverages Angular 2's https://angular.io/api/core/Renderer2 API, as well as https://angular.io/api/core/RendererFactory2 to instanciate it. It could be that I'm not using the proper instance in the right view, but I honestly have no idea with my knowledge.
The text was updated successfully, but these errors were encountered: