Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use include_byte! on a file once across templates #72

Closed
GuillaumeGomez opened this issue Jul 12, 2024 · 1 comment · Fixed by #87
Closed

Only use include_byte! on a file once across templates #72

GuillaumeGomez opened this issue Jul 12, 2024 · 1 comment · Fixed by #87

Comments

@GuillaumeGomez
Copy link
Contributor

Currently, everytime we encounter an include or an extends, we add an include_byte! call in the code. It's pretty bad and since we now keep things across the process, I think we should also keep this information to know if we actually need to generate another include_byte! call.

@GuillaumeGomez
Copy link
Contributor Author

As discussed in #85, because of incremental compilation, it might ont have the desired behaviour. Eventually we could think about limiting duplicated include for a given type, but I'm not sure it's worth it at this point. Gonna leave it open for now in case I have some new idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant